Skip to content

Bug in passing --param to ve_run_cli #1241

@davidorme

Description

@davidorme

The current code relies on _parse_command_line_params modifying the passed in override_params dictionary in place. Unfortunately, the value of that object is replaced here:

for param_str in params_str:
param_dict = _parse_param_str(param_str)
override_params, conflicts = merge_configuration_dicts(
override_params, param_dict
)

The merge_config_dictionaries function deep copies its inputs, so the returned override_params object is not the same as the passed in one. When the function returns, the original dictionary is untouched and so none of the changed parameters are enforced.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions