Litter variable unit problems

[jacobcook1995]

Making this issue as I've noticed some problems in the variables registry for litter variables. I will update this list as I notice them:

[x] herbivory_waste_leaf_lignin is unit less, this is a problem as saying lignin concentration has multiple possible "unit less expressions". Unit should be "kg lignin C (kg C)^-1"
[x] lignin_above_structural, lignin_below_structural and lignin_woody all have a unit of "kg lignin (kg C)^-1" which is incorrect as it should be "kg lignin C (kg C)^-1"
[x] Similarly root_lignin, stem_lignin and senesced_leaf_lignin all should have units of "kg lignin C (kg C)^-1"

[nickwctan]

I actually wanted inquire exactly why herbivory_waste_leaf_lginin is a variable, and not a constant.

As of now, it is a (constant) proportion of 0.25 (in decay.py) so i wonder why is it in array table as a variable when its a constant proportion. Is it so that the variable is already there when/if there is a need to change it into an equation in the future?

[jacobcook1995]

Yep at the moment it could just be a constant. In future it should be a variable though, so that it can match the lignin content of the actual leaves consumed by the animals. The 0.25 constant that wrote into the HerbivoryWaste classes is really just there as placeholder so that I can get the overall flow working

But this is something I need to change once herbivory is fully up and running (see #1361)

[nickwctan]

Perfect thanks!