Is your feature request related to a problem? Please describe.
The Config.build_schema method is now where module registration occurs and - in the process of running this method - the model information for the configuration is loaded and validated. The vr_run.select_models function then separately looks up requested models in the MODULE_REGISTRY and traps unknown models.
This is repetitive: build_schema has already seen this list of requested models, so it makes more sense for Config.build_schema (possibly under a new name) to populates a Config.models attribute with a dictionary of the requested models, which can then just be used in vr_run.
Describe the solution you'd like
Delete select_models and replace with functionality in Config.
Is your feature request related to a problem? Please describe.
The
Config.build_schemamethod is now where module registration occurs and - in the process of running this method - the model information for the configuration is loaded and validated. Thevr_run.select_modelsfunction then separately looks up requested models in theMODULE_REGISTRYand traps unknown models.This is repetitive:
build_schemahas already seen this list of requested models, so it makes more sense forConfig.build_schema(possibly under a new name) to populates aConfig.modelsattribute with a dictionary of the requested models, which can then just be used invr_run.Describe the solution you'd like
Delete
select_modelsand replace with functionality inConfig.