Skip to content

vr_full_model_configuration.toml file should be renamed #808

@alexdewar

Description

@alexdewar

I just noticed this when updating the pinned version of VE used by the snakemake template repo.

It seems like while most places in the code have been updated to use the new VE naming scheme, there are still a few places where VR is used. The only user-facing one I noticed is the vr_full_model_configuration.toml file.

Here are the others:

❯ git grep -in vr virtual_ecosystem/
virtual_ecosystem/core/logger.py:93:     This function adds a FileHandler with the name ``vr_logfile`` to
virtual_ecosystem/core/logger.py:107:        if isinstance(handler, logging.FileHandler) and handler.name == "vr_logfile":
virtual_ecosystem/core/logger.py:119:    handler.name = "vr_logfile"
virtual_ecosystem/core/logger.py:127:    This function attempts to remove the ``vr_logfile`` FileHandler that is added by
virtual_ecosystem/core/logger.py:135:        vr_logfile = next(
virtual_ecosystem/core/logger.py:136:            handler for handler in LOGGER.handlers if handler.name == "vr_logfile"
virtual_ecosystem/core/logger.py:141:    vr_logfile.close()
virtual_ecosystem/core/logger.py:142:    LOGGER.removeHandler(vr_logfile)
virtual_ecosystem/core/module_schema.json:170:                     "default": "vr_full_model_configuration.toml",
virtual_ecosystem/entry_points.py:131:    `vr_full_model_configuration.toml`. This can be disabled by setting the
Binary file virtual_ecosystem/example_data/source/ERA5_land.nc matches

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions