Skip to content

Removed bulk density from the soil model as it isn't actually used#1005

Merged
jacobcook1995 merged 1 commit intodevelopfrom
1002-bulk-density-is-defined-as-part-of-the-soil-model-setup-but-not-used
Aug 20, 2025
Merged

Removed bulk density from the soil model as it isn't actually used#1005
jacobcook1995 merged 1 commit intodevelopfrom
1002-bulk-density-is-defined-as-part-of-the-soil-model-setup-but-not-used

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR removes all uses of bulk density from the soil model associated files as it isn't actually used there (@vgro uses it in a different way in the abiotic/hydrology models)

Fixes #1002

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (8e4416d) to head (a0cd133).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1005      +/-   ##
===========================================
+ Coverage    94.91%   94.93%   +0.01%     
===========================================
  Files           80       80              
  Lines         6632     6631       -1     
===========================================
  Hits          6295     6295              
+ Misses         337      336       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobcook1995 jacobcook1995 merged commit 61f557a into develop Aug 20, 2025
13 checks passed
@jacobcook1995 jacobcook1995 deleted the 1002-bulk-density-is-defined-as-part-of-the-soil-model-setup-but-not-used branch August 20, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk density is defined as part of the soil model setup but not used

3 participants