Conversation
…8-animal---animal-plant-piping-update
…t_resource_in_territory method.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1012 +/- ##
===========================================
+ Coverage 94.93% 95.11% +0.18%
===========================================
Files 80 80
Lines 6631 6693 +62
===========================================
+ Hits 6295 6366 +71
+ Misses 336 327 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobcook1995
left a comment
There was a problem hiding this comment.
This seems to be completely consistent with how the previous litter model piping is done. (so there might still be issues, but if there are they will be broader than this PR).
Happy for this to be merged once tests are added
| if diet_type & DietType.MUSHROOMS: | ||
| # mushroom pool | ||
| result["fungal_fruiting_bodies"] = (0.0, 0.0) | ||
| if diet_type & DietType.FUNGI: |
There was a problem hiding this comment.
Is it worth calling this diet type something more specific like SOIL_FUNGI, to really differentiate it from MUSHROOMS?
There was a problem hiding this comment.
I think this is a solid idea but I'll need to do a passthrough later on to clean up the diet language and can do it then, if that works for you.
There was a problem hiding this comment.
Yep that works for me (I guess this is mainly something that will cause you confusion, as I doubt I will be looking at this code)
| herbivory_waste_pools=None, | ||
| ) | ||
|
|
||
| def delta_mass_pomivory( |
Description
I have made a separate PR for the whole soil foraging system. The new plant piping will be done separately. This portion was expedited as Jacob is going on holiday.
There shouldn't be anything actually new here, just new versions of existing things to handle the integration of mushrooms, soil fungi, pom, and bacteria. I have gone with mushrooms as the diet name for fruiting bodies because underscores don't work with my naming system.
New Traits
New methods:
Modified methods
Fixes # (issue)
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks