Skip to content

975 test abiotic model with no canopy#1021

Merged
vgro merged 10 commits intodevelopfrom
975-test-abiotic-model-with-no-canopy
Sep 8, 2025
Merged

975 test abiotic model with no canopy#1021
vgro merged 10 commits intodevelopfrom
975-test-abiotic-model-with-no-canopy

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Sep 2, 2025

This PR updates the dummy climate data with varying canopy to have one grid cell without vegetation. The intention is to check that the model behaves sensibly without vegetation (not considering the potential grass layer).

Fixes #975

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Sep 2, 2025 that may be closed by this pull request
@vgro vgro requested a review from davidorme September 2, 2025 15:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.13%. Comparing base (810332c) to head (d81d32f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1021   +/-   ##
========================================
  Coverage    95.13%   95.13%           
========================================
  Files           80       80           
  Lines         6722     6722           
========================================
  Hits          6395     6395           
  Misses         327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested review from dalonsoa and davidorme and removed request for davidorme September 6, 2025 14:55
Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Isn't it useful that I presciently duplicated the last column so we can change it to no canopy without getting rid of the single layer case 😄

I think I only did this so that the inputs weren't square: square inputs are an absolute sitting duck for accidental matrix transposition bugs.

@vgro vgro merged commit 14fff18 into develop Sep 8, 2025
13 checks passed
@vgro vgro deleted the 975-test-abiotic-model-with-no-canopy branch September 8, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test abiotic model with no canopy

3 participants