Merged
Conversation
…h one unvegetated grid cell
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1021 +/- ##
========================================
Coverage 95.13% 95.13%
========================================
Files 80 80
Lines 6722 6722
========================================
Hits 6395 6395
Misses 327 327 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidorme
approved these changes
Sep 8, 2025
Collaborator
davidorme
left a comment
There was a problem hiding this comment.
LGTM - Isn't it useful that I presciently duplicated the last column so we can change it to no canopy without getting rid of the single layer case 😄
I think I only did this so that the inputs weren't square: square inputs are an absolute sitting duck for accidental matrix transposition bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dummy climate data with varying canopy to have one grid cell without vegetation. The intention is to check that the model behaves sensibly without vegetation (not considering the potential grass layer).
Fixes #975
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks