Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1023 +/- ##
========================================
Coverage 95.13% 95.13%
========================================
Files 80 80
Lines 6722 6722
========================================
Hits 6395 6395
Misses 327 327 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexdewar
approved these changes
Sep 4, 2025
Collaborator
alexdewar
left a comment
There was a problem hiding this comment.
LGTM! I think this makes sense.
alexdewar
reviewed
Sep 4, 2025
| run: | | ||
| cd docs | ||
| poetry run sphinx-build -W --keep-going source build | ||
| poetry run sphinx-build --jobs auto -W --keep-going source build |
Collaborator
There was a problem hiding this comment.
Would it also work if you just ran make here? Or will it not run without the poetry run prefix?
Collaborator
Author
There was a problem hiding this comment.
I think poetry run make would work - but I think we probably do want to run the local sphinx-build in a slightly different way to the CI? So fail fast and not keep going locally but find everything wrong on CI? Doesn't make a huge difference but I'll leave as is for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR follows @alexdewar's suggestion to use
pytest-xdistto speed up testing. We're still going to run intotest_ve_runbeing slow, but it should speed up testing generally. It also adds--jobs autoto thesphinxbuilding options to distribute the running of MyST notebooks.Fixes #941
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks