Skip to content

Updating stoichiometry names#1027

Merged
davidorme merged 2 commits intodevelopfrom
1026-typo-in-plant-stoichiometry
Sep 5, 2025
Merged

Updating stoichiometry names#1027
davidorme merged 2 commits intodevelopfrom
1026-typo-in-plant-stoichiometry

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

@davidorme davidorme commented Sep 5, 2025

Description

Incredibly picky, but the plant stoichiometry code has a typo stochiometry -> stoichiometry that we didn't spot. This also caught a couple of typos in comments elsewhere in the codebase. I've also fixed stochiometric -> stoichiometric and stochiometries -> stoichiometries.

Fixes #1026

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Sep 5, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.13%. Comparing base (c79a194) to head (8ede542).
⚠️ Report is 1299 commits behind head on develop.

Files with missing lines Patch % Lines
virtual_ecosystem/models/plants/plants_model.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1027   +/-   ##
========================================
  Coverage    95.13%   95.13%           
========================================
  Files           80       80           
  Lines         6722     6722           
========================================
  Hits          6395     6395           
  Misses         327      327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sallymatson sallymatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's totally my bad. Thanks for fixing David!! And for being a better speller than me!!!

@davidorme davidorme merged commit 810332c into develop Sep 5, 2025
13 checks passed
@davidorme davidorme deleted the 1026-typo-in-plant-stoichiometry branch September 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in plant stoichiometry class and module name

3 participants