Skip to content

Calculate plant nutrient uptake based on transipration.#1053

Merged
sallymatson merged 5 commits intodevelopfrom
1051-bug-fixes-in-np-uptake
Sep 25, 2025
Merged

Calculate plant nutrient uptake based on transipration.#1053
sallymatson merged 5 commits intodevelopfrom
1051-bug-fixes-in-np-uptake

Conversation

@sallymatson
Copy link
Copy Markdown
Collaborator

@sallymatson sallymatson commented Sep 23, 2025

Description

Remove the dummy calculation of plant nutrient uptake and calculate it based on transpiration and concentration.

Fixes #1051

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@sallymatson sallymatson linked an issue Sep 23, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.20%. Comparing base (267538d) to head (daa974b).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1053   +/-   ##
========================================
  Coverage    95.19%   95.20%           
========================================
  Files           80       80           
  Lines         6770     6775    +5     
========================================
+ Hits          6445     6450    +5     
  Misses         325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all work from the soil side!

Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sallymatson sallymatson merged commit de07bf3 into develop Sep 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug fixes in N/P uptake

4 participants