Skip to content

Retire the plant schema [pft_definition] option#1060

Merged
davidorme merged 9 commits intodevelopfrom
1038-retire-the-pft_definition-option
Oct 1, 2025
Merged

Retire the plant schema [pft_definition] option#1060
davidorme merged 9 commits intodevelopfrom
1038-retire-the-pft_definition-option

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

Description

This PR simplifies the config options for the PlantsModel by removing the TOML array [[plants.pft_definition]] approach completely and only using the pft_definitions_path option.

Fixes #1038

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Sep 29, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.20%. Comparing base (975a39a) to head (1d18d26).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...irtual_ecosystem/models/plants/functional_types.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
- Coverage    95.25%   95.20%   -0.05%     
===========================================
  Files           81       81              
  Lines         6895     6889       -6     
===========================================
- Hits          6568     6559       -9     
- Misses         327      330       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sallymatson sallymatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidorme davidorme merged commit ce1215e into develop Oct 1, 2025
13 checks passed
@davidorme davidorme deleted the 1038-retire-the-pft_definition-option branch October 1, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire the pft_definition option in the PlantsModel schema

3 participants