Conversation
…esolve-shared-constants-between-abiotic-and-abiotic-simple-to-allow-configuration
…one constants class
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1139 +/- ##
===========================================
- Coverage 94.33% 94.33% -0.01%
===========================================
Files 70 70
Lines 7029 7024 -5
===========================================
- Hits 6631 6626 -5
Misses 398 398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…otic-and-abiotic-simple-to-allow-configuration
…otic-and-abiotic-simple-to-allow-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures the configuration of the
abioticandabiotic_simplemodels to provide a single standalone configuration for each model. The two models no longer need to supply bothabiotic_constantsandabiotic_simple_constants. This is important to make the models fully configurable - users need to be able to configure all settings for , for example, theabioticmodel from within the[abiotic]configuration section.It does this by:
AbioticSharedConstants) that contains only soil and leaf emissivity. These constants are required by both models.AbioticConstantsandAbioticSimpleConstantsthen build on that shared class to add model specific configuration. For the simple model, that is justinitial_net_radiation- there was also asaturation_vapour_pressure_factorsfield but that was completely unused in the model code. For the full model, there are a lot of other constants.[abiotic.bounds]configuration section. So, these bounds are defined in a single place but are now available directly from within a single model config.The PR then updates the model code to remove all of the parallel usage of
abioticandabiotic_simpleconstants and just uses the single model configuration.Closes #1137
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks