Conversation
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
+ Coverage 94.33% 94.34% +0.01%
===========================================
Files 70 70
Lines 7024 7044 +20
===========================================
+ Hits 6626 6646 +20
Misses 398 398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sallymatson
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
pyrealmsection to thecoreconfiguration that provides instances of pyrealm'sPModelConstandCoreConst. These can be configured using the TOML - there is a residual issue thatnumpyarrays in thepyrealmconfig cannot currently be serialised, so user configuration of pyrealm is not captured in exported config TOMLs.fixture_pyrealm_configfixture totests/conftest.pyand uses that in all tests that previously used standalone imports of pyrealm constants.Fixes #1140
Also fixes #697 - which was PlantsModel specific
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks