Skip to content

Fixing incorrect volume to area conversion in fungal fruiting body production rate calculation#1152

Merged
jacobcook1995 merged 1 commit intodevelopfrom
1151-unit-conversion-error-fungal-fruiting-body-creation
Nov 18, 2025
Merged

Fixing incorrect volume to area conversion in fungal fruiting body production rate calculation#1152
jacobcook1995 merged 1 commit intodevelopfrom
1151-unit-conversion-error-fungal-fruiting-body-creation

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

Small fix that stops the fungi from spontaneously generating carbon

Fixes #1151

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Nov 18, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.35%. Comparing base (3c5979a) to head (3e91e34).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1152   +/-   ##
========================================
  Coverage    94.35%   94.35%           
========================================
  Files           70       70           
  Lines         7049     7049           
========================================
  Hits          6651     6651           
  Misses         398      398           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobcook1995 jacobcook1995 merged commit f7e89fd into develop Nov 18, 2025
31 of 34 checks passed
@jacobcook1995 jacobcook1995 deleted the 1151-unit-conversion-error-fungal-fruiting-body-creation branch November 18, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit conversion error fungal fruiting body creation

4 participants