Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1153 +/- ##
========================================
Coverage 94.35% 94.36%
========================================
Files 70 70
Lines 7049 7041 -8
========================================
- Hits 6651 6644 -7
+ Misses 398 397 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobcook1995
approved these changes
Nov 19, 2025
Collaborator
jacobcook1995
left a comment
There was a problem hiding this comment.
Removing the looping seems sensible to me!
| return_fluxes=False, | ||
| maxiter=10000, | ||
| ) | ||
| print(canopy_temperature) |
Collaborator
There was a problem hiding this comment.
Guess this line should be deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets rid of the loop for different time steps because it is currently not relevant and causes problems with getting the right time interval for the integration.
I also corrected the unit of latent heat of vaporization (*1000 everywhere) and corrected the signs of energy fluxes in places ( the convention is negative away from the surface towards the atmosphere).
I also found out why the canopy temperatures go crazy, spoiler alert: it's not the Newton method, but will address this in #1022 .
Fixes #1149
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks