1154 energy balance for understory vegetation#1183
Merged
Conversation
… offline, problem with negative surface precipitation. microclimate test fails, nan soil temperature
… to soil, surface vegetation to conftest
…storey flux added
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1183 +/- ##
===========================================
+ Coverage 94.39% 94.43% +0.04%
===========================================
Files 71 71
Lines 7169 7229 +60
===========================================
+ Hits 6767 6827 +60
Misses 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobcook1995
approved these changes
Dec 8, 2025
Collaborator
jacobcook1995
left a comment
There was a problem hiding this comment.
I can't follow all of the science, but it looks good to me in general, only had a few minor comments
…://github.com/ImperialCollegeLondon/virtual_rainforest into 1154-energy-balance-for-understory-vegetation
davidorme
approved these changes
Dec 8, 2025
Collaborator
davidorme
left a comment
There was a problem hiding this comment.
All looks good to me - well documented too!
vgro
commented
Dec 8, 2025
docs/source/virtual_ecosystem/implementation/abiotic_implementation.md
Outdated
Show resolved
Hide resolved
vgro
commented
Dec 8, 2025
docs/source/virtual_ecosystem/implementation/abiotic_implementation.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the energy balance for the understorey vegetation following the idea of the forest floor litter model by J. Ogee and Y. Brunet (2002).
The main step is to solve the energy balance for the understorey, similar to the canopy, and add a conductive flux towards the soil. The updated docs are here.
I also fixed the vertical mixing which caused the model to crash and added some functions to make things a bit tidies, like
update_profile_from_reference.This step revealed a whole bunch of gaps and problems which should be addressed separately to stop this PR from getting more complicated (and clarified some of the older issues, should be doable now):
Fixes #1154
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks