Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1194 +/- ##
========================================
Coverage 95.03% 95.03%
========================================
Files 71 71
Lines 7276 7276
========================================
Hits 6915 6915
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@nickwctan Sorry for the slow review. I've overhauled the page to update it to your changes. Mostly, I've moved Some points:
|
nickwctan
left a comment
There was a problem hiding this comment.
LGTM, just have a minor comment on your code.
|
|
||
| ```{code-block} shell | ||
| $ eval $(poetry env activate) | ||
| (test-project-for-test) $ |
There was a problem hiding this comment.
Just not sure what this does?
(test-project-for-test) $
I get an error when running it
There was a problem hiding this comment.
It's not code, it's a message that appears before the command line prompt to show you're in the poetry environment. I'll clarify it.
There was a problem hiding this comment.
It would be helpful if used the right name for a start 😁 should be (virtual-ecosystem)
There was a problem hiding this comment.
in my terminal, it shows that i am in the env in brackets and then my laptop's name and directory. See below:
(virtual-ecosystem-py3.11) nick@nick-tp:~/SEARRP/virtual_ecosystem$
There was a problem hiding this comment.
Sure but the command prompt is configured by individual users independently of the VE project 😀 I'll put something generic to make it clear
Description
This PR is a follow up of my user experience on installing pyenv and poetry for running the VE following the instructions of the documentation we have. I would like to address some inconsistencies and hiccups I faced while following the documentation. Here are my suggestions of ways to improve them. Comments are welcome.
Caveat: All improvements are based on Linux system. There might/might not be any differences for Windows users.
Fixes # (issue)
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks