Skip to content

Small fixes to prevent negative microbial populations from propagating further errors#1200

Merged
jacobcook1995 merged 4 commits intodevelopfrom
1198-add-sensible-handling-of-negative-mycorrhizal-populations
Dec 16, 2025
Merged

Small fixes to prevent negative microbial populations from propagating further errors#1200
jacobcook1995 merged 4 commits intodevelopfrom
1198-add-sensible-handling-of-negative-mycorrhizal-populations

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

Two changes here.

  1. Negative microbial populations now no longer lose a negative amount of biomass to maintenance. Instead the biomass loss rate is zero
  2. The animal available microbial consumption pools now treat any negative microbial pool as zero (previously this only happened for the two mycorrhizal pools)

These fixes are needed not just for the mycorrhizal problems (which a better long term solution for is described in #1197), but also because animal consumption will be potentially able to drive microbial pools negative.

Fixes #1198

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Dec 15, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (6407711) to head (326f48c).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1200   +/-   ##
========================================
  Coverage    95.00%   95.00%           
========================================
  Files           71       71           
  Lines         7269     7269           
========================================
  Hits          6906     6906           
  Misses         363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobcook1995 jacobcook1995 requested a review from vgro December 15, 2025 14:24
Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit 031afce into develop Dec 16, 2025
13 checks passed
@jacobcook1995 jacobcook1995 deleted the 1198-add-sensible-handling-of-negative-mycorrhizal-populations branch December 16, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sensible handling of negative mycorrhizal populations

3 participants