Add flow of excrement decay into the soil model#1224
Merged
jacobcook1995 merged 4 commits intodevelopfrom Jan 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1224 +/- ##
========================================
Coverage 95.03% 95.03%
========================================
Files 71 71
Lines 7278 7278
========================================
Hits 6917 6917
Misses 361 361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TaranRallings
approved these changes
Jan 8, 2026
Collaborator
TaranRallings
left a comment
There was a problem hiding this comment.
Straightforward enough, LGTM!
sallymatson
reviewed
Jan 8, 2026
sallymatson
approved these changes
Jan 8, 2026
Collaborator
sallymatson
left a comment
There was a problem hiding this comment.
LGTM ! Left one minor comment but not blocking by any means
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the soil model so that it now actually uses the excrement and carcass flows. For this exchange I've now started using the CNP triplets so that I only need to use 2 variables for the exchanges rather than 6.
Fixes #1177
@sallymatson and @TaranRallings, I've added both of you as reviewers because I want to check that I have used the CNP triplets correctly and that I haven't messed up anything in the animal model. No rush at all with reviewing this, I just wanted to get the PR made before I went on annual leave
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks