Skip to content

activated latent heat flux, introduces shorter indexing#1231

Merged
vgro merged 1 commit intodevelopfrom
1230-include-latent-heat-flux-in-understorey-energy-balance
Dec 17, 2025
Merged

activated latent heat flux, introduces shorter indexing#1231
vgro merged 1 commit intodevelopfrom
1230-include-latent-heat-flux-in-understorey-energy-balance

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Dec 17, 2025

This PR adds latent heat flux to the understorey energy balance. The equation is slightly different,, it has been updated since the first draft.
I also added indices for common layers to avoid these very long lines.

Fixes # 1230

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Dec 17, 2025 that may be closed by this pull request
@vgro vgro requested a review from jacobcook1995 December 17, 2025 09:57
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.95%. Comparing base (0696c7f) to head (8fccd52).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1231   +/-   ##
========================================
  Coverage    94.95%   94.95%           
========================================
  Files           71       71           
  Lines         7288     7293    +5     
========================================
+ Hits          6920     6925    +5     
  Misses         368      368           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro merged commit eb1cb98 into develop Dec 17, 2025
13 checks passed
@vgro vgro deleted the 1230-include-latent-heat-flux-in-understorey-energy-balance branch December 17, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

include latent heat flux in understorey energy balance

3 participants