Deprecate C:N:P ratios between plants and litter#1233
Merged
jacobcook1995 merged 17 commits intodevelopfrom Jan 22, 2026
Merged
Deprecate C:N:P ratios between plants and litter#1233jacobcook1995 merged 17 commits intodevelopfrom
jacobcook1995 merged 17 commits intodevelopfrom
Conversation
… the litter model
Closed
Collaborator
Author
|
@sallymatson, I've made the change we discussed yesterday and deleted the reproductive tissue handling entirely from the litter model. It's now ready to review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1233 +/- ##
===========================================
- Coverage 95.05% 95.02% -0.03%
===========================================
Files 71 71
Lines 7317 7274 -43
===========================================
- Hits 6955 6912 -43
Misses 362 362 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sallymatson
approved these changes
Jan 9, 2026
Collaborator
sallymatson
left a comment
There was a problem hiding this comment.
LGTM !! Thanks for making all the deletions, gonna feel so nice in the plants model after this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the variables that go between plants and litter that use the old (one variable per element) style rather than the new elemental mass triplet format.
I've done this for foliage, roots and stems.
However, I'm leaving this PR as a draft as I wasn't sure about the reproductive tissues case. Here, there are several variables marked for deprecation which are generated within
allocate_gpp(which isn't a function I feel confident messing around with), these are "plant_reproductive_tissue_turnover", "fallen_non_propagule_c_mass", "plant_rt_turnover_n_mass" and "plant_rt_turnover_p_mass".I guess the whole flow of fruits etc to litter is going to be replaced with something that occurs via the animals/the seedbank so a lot of this stuff could just be ripped out as it will become redundant soon. But, wanted to check what the plans are before going ahead and doing that
I guess this is something that makes most sense to chat about in person in the new year
Fixes #1131
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks