Skip to content

1243 sort out abiotic constants for calibration#1244

Merged
vgro merged 2 commits intodevelopfrom
1243-sort-out-abiotic-constants-for-calibration
Jan 6, 2026
Merged

1243 sort out abiotic constants for calibration#1244
vgro merged 2 commits intodevelopfrom
1243-sort-out-abiotic-constants-for-calibration

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Jan 6, 2026

This PR removed unused abiotic and hydrology constants.

Fixes #1243

@vgro vgro linked an issue Jan 6, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (f6dbe56) to head (7280055).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1244      +/-   ##
===========================================
- Coverage    95.04%   95.03%   -0.01%     
===========================================
  Files           71       71              
  Lines         7292     7278      -14     
===========================================
- Hits          6931     6917      -14     
  Misses         361      361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from jacobcook1995 January 6, 2026 11:18
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor query but otherwise looks good to go!

@vgro vgro merged commit 0f4f9ed into develop Jan 6, 2026
13 checks passed
@vgro vgro deleted the 1243-sort-out-abiotic-constants-for-calibration branch January 6, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sort out abiotic constants for calibration

4 participants