Skip to content

added abiotic tools for subdaily#1274

Merged
vgro merged 3 commits intodevelopfrom
1272-add-functions-to-enable-subdaily-abiotic-model
Jan 22, 2026
Merged

added abiotic tools for subdaily#1274
vgro merged 3 commits intodevelopfrom
1272-add-functions-to-enable-subdaily-abiotic-model

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Jan 22, 2026

This PR adds a set of functions to run the abiotic model in subdaily time steps. Some functions are a bit simplified but should help with the initial test.

Fixes #1272

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Jan 22, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (be9821b) to head (feb9206).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1274      +/-   ##
===========================================
+ Coverage    94.97%   95.00%   +0.02%     
===========================================
  Files           71       71              
  Lines         7344     7386      +42     
===========================================
+ Hits          6975     7017      +42     
  Misses         369      369              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from jacobcook1995 January 22, 2026 14:16
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit c150a5e into develop Jan 22, 2026
13 checks passed
@vgro vgro deleted the 1272-add-functions-to-enable-subdaily-abiotic-model branch January 22, 2026 15:42
@vgro vgro restored the 1272-add-functions-to-enable-subdaily-abiotic-model branch January 22, 2026 15:42
@vgro vgro deleted the 1272-add-functions-to-enable-subdaily-abiotic-model branch March 19, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add functions to enable subdaily abiotic model

3 participants