Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1276 +/- ##
========================================
Coverage 94.97% 94.97%
========================================
Files 71 71
Lines 7344 7344
========================================
Hits 6975 6975
Misses 369 369 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vgro
approved these changes
Jan 22, 2026
Collaborator
vgro
left a comment
There was a problem hiding this comment.
LGTM.
If you don't mind making one more small change, could you change the colors in the plots, something like this (not urgent)
var_name = "soil_moisture"
cell_to_plot = 25
soil_layers = ve_example.layers[-2:]
n_layers = len(soil_layers)
# Choose colormaps for each dataset
ve_cmap = cm.Blues(np.linspace(0.5, 1, n_layers)) # Blue shades for ve_example
hydro_cmap = cm.Reds(np.linspace(0.5, 1, n_layers)) # Red shades for hydrodefault
for i, layer in enumerate(soil_layers.values):
plt.plot(
ve_example["time_index"],
ve_example[var_name].sel(cell_id=cell_to_plot, layers=layer),
label=f"VE Example - Layer {layer}",
linestyle="-",
color=ve_cmap[i],
)
plt.plot(
hydrodefault["time_index"],
hydrodefault[var_name].sel(cell_id=cell_to_plot, layers=layer),
label=f"HydroConst {layer}",
linestyle="--",
color=hydro_cmap[i],
)
plt.xlabel("Time")
plt.ylabel(var_name)
plt.title(f"{var_name} for cell {cell_to_plot} (soil layers)")
plt.legend()
plt.show()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR saves a version of the
virtual_ecosystem_in_use.ipynbthat actually includes the graphs (something @vgro mentioned that I missed from the previous PR)The graphs show 🥳
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks