Fixing calculate atmospheric layer geometry#1352
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
- Coverage 94.96% 94.95% -0.01%
===========================================
Files 71 71
Lines 7382 7371 -11
===========================================
- Hits 7010 6999 -11
Misses 372 372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@vgro - as you're on leave, I've asked @jacobcook1995 to review this to get the fix down into |
jacobcook1995
approved these changes
Feb 19, 2026
Collaborator
jacobcook1995
left a comment
There was a problem hiding this comment.
LGTM, but yes agree @vgro should look at this once she is back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
calculate_atmospheric_layer_geometrythat was calculating heights between cells rather than between canopy layers.compute_layer_thickness_for_varying_canopyfunction to use a faster parallelized calculation.bottleneckto the package dependencies to speed this calculation up. @dalonsoa I think some of the performance enhancement may be trying to spot where we can usebnFixes #1351
Makes partial progress to solving the issues in #1314 (or at least, finds the next bug).
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks