Delete unused variables from soil/litter testing#1358
Merged
jacobcook1995 merged 9 commits intodevelopfrom Feb 23, 2026
Merged
Conversation
…se senesced_leaf_lignin
… longer used by the soil model
…mpletely outdated
…o the data object in testing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1358 +/- ##
===========================================
- Coverage 94.85% 94.85% -0.01%
===========================================
Files 71 71
Lines 7392 7388 -4
===========================================
- Hits 7012 7008 -4
Misses 380 380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Just to note that I asked @jacobcook1995 to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deletes all the variables that are not described in the
variables.tomlfrom the places where they are used. Primarily this involves removing places where I just added extra variables to the data object in testing for convenience's sake.@davidorme, I've removed "leaf_lignin" from the plants model entirely, as the litter model only uses "senesced_leaf_lignin", and I don't think a difference in senesced concentrations makes sense for lignin (only for N and P). Let me know if you are happy with this change, happy to take a different approach if you object to this change.
Fixes #1308
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks