Naive fix for too high metabolic fractions#1360
Merged
jacobcook1995 merged 2 commits intodevelopfrom Feb 23, 2026
Conversation
… is constrained by the lignin proportion
davidorme
approved these changes
Feb 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1360 +/- ##
===========================================
+ Coverage 94.95% 94.99% +0.03%
===========================================
Files 71 71
Lines 7369 7366 -3
===========================================
Hits 6997 6997
+ Misses 372 369 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a naive fix for metabolic fractions of litter input being too high, basically be converting the existing test to a step that forces the value to conform. This will be handled more elegantly when I get round to addressing #1010, but I think this quick fix is good enough for now.
I've also changed what this function raises errors for, so that it now checks for lignin proportions outside the physically possible range, which would break the logic of the function.
Fixes #1359
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks