Skip to content

corrected calculation of midpoints#1364

Merged
vgro merged 2 commits intodevelopfrom
1363-correct-layer-midpoints-calculation
Feb 23, 2026
Merged

corrected calculation of midpoints#1364
vgro merged 2 commits intodevelopfrom
1363-correct-layer-midpoints-calculation

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Feb 23, 2026

This PR updates the caluclation of layer midpoints.

Fixes #1363

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Feb 23, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.85%. Comparing base (d6d8258) to head (e2ddcf5).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1364      +/-   ##
===========================================
- Coverage    94.85%   94.85%   -0.01%     
===========================================
  Files           71       71              
  Lines         7388     7387       -1     
===========================================
- Hits          7008     7007       -1     
  Misses         380      380              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from jacobcook1995 February 23, 2026 14:10
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit 8a26398 into develop Feb 23, 2026
13 checks passed
@vgro vgro deleted the 1363-correct-layer-midpoints-calculation branch February 23, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

correct layer midpoints calculation

3 participants