Skip to content

Animal - Grid size alignment#1404

Merged
TaranRallings merged 5 commits intodevelopfrom
1403-animal---replace-fixed-area-with-grid-size-reference
Mar 6, 2026
Merged

Animal - Grid size alignment#1404
TaranRallings merged 5 commits intodevelopfrom
1403-animal---replace-fixed-area-with-grid-size-reference

Conversation

@TaranRallings
Copy link
Copy Markdown
Collaborator

Description

This updates some remaining toy value grid size references to key off grid.cell_area as well as converts two remaining parameters from ha rates to m2 rates.

Fixes #1403

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.87%. Comparing base (ad3f5f1) to head (5f26329).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1404      +/-   ##
===========================================
+ Coverage    94.84%   94.87%   +0.02%     
===========================================
  Files           71       71              
  Lines         7455     7455              
===========================================
+ Hits          7071     7073       +2     
+ Misses         384      382       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@nickwctan nickwctan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jop, LGTM. I am guessing the CNP capitalisation in array_resource.py is just typo corrections?

@TaranRallings
Copy link
Copy Markdown
Collaborator Author

Jop, LGTM. I am guessing the CNP capitalisation in array_resource.py is just typo corrections?

Yeah, that was just aligning the forms.

@TaranRallings TaranRallings merged commit 55c356b into develop Mar 6, 2026
13 checks passed
@TaranRallings TaranRallings deleted the 1403-animal---replace-fixed-area-with-grid-size-reference branch March 6, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Animal - Replace fixed area with grid size reference.

3 participants