Skip to content

Convert soil + litter exchange variables to be biomass triplets#1415

Merged
jacobcook1995 merged 3 commits intodevelopfrom
1225-change-animal-to-soillitter-flows-to-use-cnp-triplets
Mar 11, 2026
Merged

Convert soil + litter exchange variables to be biomass triplets#1415
jacobcook1995 merged 3 commits intodevelopfrom
1225-change-animal-to-soillitter-flows-to-use-cnp-triplets

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR changes the remaining variables that pass stoichiometric information into/out of the litter and soil models to use biomass triplets.

The two relevant variables I changed are animal_pom_consumption_* and litter_mineralisation_rate_*. Everything else either wasn't a triplet (e.g. plant_ammonium_uptake or ectomycorrhizal_n_supply and ectomycorrhizal_p_supply) or had already been moved to triplet format

Fixes #1225

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Mar 9, 2026 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (e9763f6) to head (0078964).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1415   +/-   ##
========================================
  Coverage    94.84%   94.84%           
========================================
  Files           71       71           
  Lines         7451     7452    +1     
========================================
+ Hits          7067     7068    +1     
  Misses         384      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@TaranRallings TaranRallings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome possum.

@jacobcook1995 jacobcook1995 merged commit 61b6ded into develop Mar 11, 2026
13 checks passed
@jacobcook1995 jacobcook1995 deleted the 1225-change-animal-to-soillitter-flows-to-use-cnp-triplets branch March 11, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change animal to soil/litter flows to use CNP triplets

3 participants