Improve description of the clay fraction variable#1437
Merged
jacobcook1995 merged 3 commits intodevelopfrom Mar 16, 2026
Merged
Improve description of the clay fraction variable#1437jacobcook1995 merged 3 commits intodevelopfrom
jacobcook1995 merged 3 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1437 +/- ##
========================================
Coverage 94.83% 94.83%
========================================
Files 71 71
Lines 7452 7452
========================================
Hits 7067 7067
Misses 385 385 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hrlai
approved these changes
Mar 16, 2026
Collaborator
hrlai
left a comment
hrlai
left a comment
There was a problem hiding this comment.
Looks good to me. I guess by size fractionalisation it is count / count, but I think it's okay in the current shape too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've improved the description of the clay fraction variable to mention that it runs between 0 and 1, i.e. that it isn't a percentage. I didn't change the unit as I guess it is really unit-less and I couldn't think of a nice way to express "this is a proportion" in simple units notation
Let me know if this seems clear enough
Fixes #1431