Conversation
Closed
4 tasks
Collaborator
Author
|
Oh great. #390 has started affecting the Mac OS runners. |
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
reviewed
Feb 22, 2024
vgro
approved these changes
Feb 22, 2024
Collaborator
vgro
left a comment
There was a problem hiding this comment.
LGTM. Just a few minor comments.
Thanks for the huge effort! Quite cool to see ow much code we have created over the last two years :-)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #392 +/- ##
========================================
Coverage 93.18% 93.18%
========================================
Files 60 60
Lines 2920 2920
========================================
Hits 2721 2721
Misses 199 199 ☔ View full report in Codecov by Sentry. |
TaranRallings
approved these changes
Feb 27, 2024
Collaborator
TaranRallings
left a comment
There was a problem hiding this comment.
LGTM!
We have written quite a bit of code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements #391:
sphinxreferences)vr_runfunction renamed tove_run. For some reason, I don't like that name, but we can fix that later!Still to do:
Fixes #391
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks