Updated TODOs across animal module code.#475
Merged
TaranRallings merged 2 commits intodevelopfrom Jul 1, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #475 +/- ##
========================================
Coverage 94.96% 94.96%
========================================
Files 70 70
Lines 3792 3792
========================================
Hits 3601 3601
Misses 191 191 ☔ View full report in Codecov by Sentry. |
dalonsoa
approved these changes
Jul 1, 2024
Collaborator
dalonsoa
left a comment
There was a problem hiding this comment.
Fantastic!
Rather than creating issues with an "Animal - ..." title, I think it will be useful to use labels to classify the issues by categories or themes. That way is also easier to filter or quickly visualise what the issues you have are about. So, I would create a label for Animal, another for Plats, etc. and use those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was suggested that I should be turning my TODOs into issues and that I should be making branches out of those issues. To begin this process I needed to clean up my TODOs and that is what I have done here.
The TODOs are now much better organized and they have been made into issues. There were a couple little docstring updates I did along the way when I realized something was out of date.
Fixes # (issue)
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks