Skip to content

Move setup step to init in Abiotic and AbioticSimple models#524

Merged
davidorme merged 4 commits intodevelopfrom
remove_setup
Aug 30, 2024
Merged

Move setup step to init in Abiotic and AbioticSimple models#524
davidorme merged 4 commits intodevelopfrom
remove_setup

Conversation

@dalonsoa
Copy link
Copy Markdown
Collaborator

Description

It was done already for the Hydrology model but I forgot to do the same for the other two. The main changes have more to do with fixing the tests than the actual change in the code.

Fixes # N/A

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@dalonsoa dalonsoa requested review from davidorme and vgro July 17, 2024 09:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (7ce59b2) to head (997f395).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #524   +/-   ##
========================================
  Coverage    94.97%   94.98%           
========================================
  Files           74       74           
  Lines         4141     4145    +4     
========================================
+ Hits          3933     3937    +4     
  Misses         208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidorme
Copy link
Copy Markdown
Collaborator

@TaranRallings - The animal model also uses a setup method, which is currently also called from within __init__, so runs twice.

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidorme davidorme merged commit f3c6f53 into develop Aug 30, 2024
@davidorme davidorme deleted the remove_setup branch August 30, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants