Move setup step to init in Abiotic and AbioticSimple models#524
Merged
Move setup step to init in Abiotic and AbioticSimple models#524
Abiotic and AbioticSimple models#524Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #524 +/- ##
========================================
Coverage 94.97% 94.98%
========================================
Files 74 74
Lines 4141 4145 +4
========================================
+ Hits 3933 3937 +4
Misses 208 208 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@TaranRallings - The animal model also uses a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It was done already for the
Hydrologymodel but I forgot to do the same for the other two. The main changes have more to do with fixing the tests than the actual change in the code.Fixes # N/A
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks