Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #548 +/- ##
========================================
Coverage 95.08% 95.09%
========================================
Files 74 74
Lines 4295 4302 +7
========================================
+ Hits 4084 4091 +7
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I'm in no rush, but if this is Ok, it will be best to merge it. The longer a PR is open, the more challenges it brings merging it for ongoing work. It is approved but I would prefer if you merge it, so it is done when it is a good time (eg. to avoid conflicts). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the current calculation of the model execution order in init and update - based on the input configuration - with another one based on the information on which variables each model initialises and which ones they require.
Using this method has identified also an inconsistency in the variables used by the
soilmodel, which I guess it is a good thing!The
dependssection of the example config files have been removed, and I had not spotted it being mentioned anywhere else, including the documentation, but let me know if I missed anything.In principle, this is the last bit of the implementation of the variables system.
Fixes #389
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks