Add waste from herbivore mechanical inefficiencies to the litter#577
Merged
jacobcook1995 merged 10 commits intodevelopfrom Oct 4, 2024
Merged
Add waste from herbivore mechanical inefficiencies to the litter#577jacobcook1995 merged 10 commits intodevelopfrom
jacobcook1995 merged 10 commits intodevelopfrom
Conversation
…han adding it as excrement
…d to the litter model and the end of the time step
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #577 +/- ##
===========================================
+ Coverage 95.04% 95.15% +0.10%
===========================================
Files 74 74
Lines 4262 4295 +33
===========================================
+ Hits 4051 4087 +36
+ Misses 211 208 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TaranRallings
approved these changes
Oct 3, 2024
Collaborator
TaranRallings
left a comment
There was a problem hiding this comment.
This LGTM. We're going to have to rework it basically immediately anyway lol.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
HebivoryWastepool which stores things that herbivores take from plants which don't reach their digestive tracks. At the moment herbivory is only implemented for leaves, so this also only works for leaves, but this should be readily extensible to other plant matter types.Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks