Skip to content

Add waste from herbivore mechanical inefficiencies to the litter#577

Merged
jacobcook1995 merged 10 commits intodevelopfrom
feature/add_herbivory_waste
Oct 4, 2024
Merged

Add waste from herbivore mechanical inefficiencies to the litter#577
jacobcook1995 merged 10 commits intodevelopfrom
feature/add_herbivory_waste

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR adds a new HebivoryWaste pool which stores things that herbivores take from plants which don't reach their digestive tracks. At the moment herbivory is only implemented for leaves, so this also only works for leaves, but this should be readily extensible to other plant matter types.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 changed the title Add waste for herbivore mechanical inefficiencies to the litter Add waste from herbivore mechanical inefficiencies to the litter Oct 3, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 3, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.15%. Comparing base (8097392) to head (5d1ee7c).
⚠️ Report is 3270 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #577      +/-   ##
===========================================
+ Coverage    95.04%   95.15%   +0.10%     
===========================================
  Files           74       74              
  Lines         4262     4295      +33     
===========================================
+ Hits          4051     4087      +36     
+ Misses         211      208       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@TaranRallings TaranRallings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. We're going to have to rework it basically immediately anyway lol.

@jacobcook1995 jacobcook1995 merged commit f8392e0 into develop Oct 4, 2024
@jacobcook1995 jacobcook1995 deleted the feature/add_herbivory_waste branch October 4, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants