Updating example data formats to consistent NetCDF4#586
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #586 +/- ##
========================================
Coverage 95.08% 95.08%
========================================
Files 74 74
Lines 4295 4295
========================================
Hits 4084 4084
Misses 211 211 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Hmm - still fails, but on different files. I'd forgotten that the testing files included a |
Collaborator
Author
|
Aha! That seems to have done it. |
Collaborator
Author
|
Annoyingly all the files have gotten larger. They're still small, but 🤷♂️ We could add compression but that adds performance overheads in reading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a first attempt to solve the failing tests issue on Windows 3.12 by updating two example data files from NetCDF3 to NetCDF4
Fixes #585 (issue)
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks