Skip to content

Updating example data formats to consistent NetCDF4#586

Merged
davidorme merged 2 commits intodevelopfrom
585-windows-312-tests-are-failing
Oct 10, 2024
Merged

Updating example data formats to consistent NetCDF4#586
davidorme merged 2 commits intodevelopfrom
585-windows-312-tests-are-failing

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

Description

This is a first attempt to solve the failing tests issue on Windows 3.12 by updating two example data files from NetCDF3 to NetCDF4

Fixes #585 (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Oct 10, 2024 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.08%. Comparing base (c0cd731) to head (2e077de).

Files with missing lines Patch % Lines
...mple_data/generation_scripts/plant_example_data.py 0.00% 1 Missing ⚠️
...tion_scripts/topofcanopy_radiation_example_data.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #586   +/-   ##
========================================
  Coverage    95.08%   95.08%           
========================================
  Files           74       74           
  Lines         4295     4295           
========================================
  Hits          4084     4084           
  Misses         211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidorme
Copy link
Copy Markdown
Collaborator Author

Hmm - still fails, but on different files. I'd forgotten that the testing files included a data directory with .nc files.

@davidorme
Copy link
Copy Markdown
Collaborator Author

Aha! That seems to have done it.

Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidorme davidorme merged commit 877ef62 into develop Oct 10, 2024
@davidorme davidorme deleted the 585-windows-312-tests-are-failing branch October 10, 2024 14:18
@davidorme
Copy link
Copy Markdown
Collaborator Author

Annoyingly all the files have gotten larger. They're still small, but 🤷‍♂️

We could add compression but that adds performance overheads in reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows 3.12 tests are failing

3 participants