Skip to content

Stop bots from running codecov upload step in CI#590

Merged
davidorme merged 1 commit intodevelopfrom
589-bot-prs-unable-to-access-codecov_token
Oct 11, 2024
Merged

Stop bots from running codecov upload step in CI#590
davidorme merged 1 commit intodevelopfrom
589-bot-prs-unable-to-access-codecov_token

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

Description

This is just adding conditionals on the execution of the codecov upload step in CI to stop bots running that step, because they don't seem (or at least codecov doesn't) to have access to the required secrets, unlike PRs from actual repo members.

Fixes #589

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue Oct 11, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 11, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.09%. Comparing base (bb1211c) to head (4f501b6).
⚠️ Report is 3224 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    95.09%   95.09%           
========================================
  Files           74       74           
  Lines         4302     4302           
========================================
  Hits          4091     4091           
  Misses         211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidorme
Copy link
Copy Markdown
Collaborator Author

Ha! To be honest I was expecting:

  1. the YAML syntax to fail or
  2. the codecov job not to run here, where it should.

@davidorme
Copy link
Copy Markdown
Collaborator Author

Lets see if the rebased dependabot merges run!

@davidorme davidorme merged commit dac7ad2 into develop Oct 11, 2024
@davidorme davidorme deleted the 589-bot-prs-unable-to-access-codecov_token branch October 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot PRs unable to access CODECOV_TOKEN

3 participants