Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #607 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 74 74
Lines 4380 4380
========================================
Hits 4169 4169
Misses 211 211 ☔ View full report in Codecov by Sentry. |
jacobcook1995
approved these changes
Oct 16, 2024
Collaborator
jacobcook1995
left a comment
There was a problem hiding this comment.
Skimmed the file changes at it looks sensible to me, happy for this to be merged once the docs build failures are fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
jupytext --pipe blackas apre-commitstep for the markdown files indocs/source, which auto-formats any Python in{code-cell}directives.[tool.jupytext])This is a little finicky and the implementation is being looked at:
mwouts/jupytext#1267
It is possible that we might be able to use
ruffhere but at present only the.ipynbformat for notebooks is supported byruff-format.astral-sh/ruff#8800 (comment)
Fixes #154
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks