Merged
Conversation
…solved and particulate forms
…ecular weight carbon
…ple classes of pool
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #616 +/- ##
===========================================
- Coverage 95.18% 95.16% -0.02%
===========================================
Files 74 74
Lines 4380 4409 +29
===========================================
+ Hits 4169 4196 +27
- Misses 211 213 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dalonsoa
requested changes
Oct 29, 2024
Collaborator
dalonsoa
left a comment
There was a problem hiding this comment.
I've made a couple of comments/suggestions, but it looks good, otherwise.
… integrated by the soil model integration
… docstring of the function to be integrated
Collaborator
Author
|
@dalonsoa, I've tried to address all your suggestions. Let me know whether the changes look okay. Cheers! |
Co-authored-by: Diego Alonso Álvarez <6095790+dalonsoa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds two new pools to track nitrogen in the soil "soil_n_pool_don" and "soil_n_pool_particulate". These pools both receive input from litter mineralisation, and the DON (dissolved organic nitrogen) pool also leaches. Both pools are organic nitrogen pools, so effectively track the nitrogen stoichiometry of their corresponding carbon pools (the low molecular weight carbon (LMWC) pool and the particulate organic matter (POM) pool). The breakdown rate of POM to LMWC therefore determines the rate at which nitrogen goes from the particulate to the dissolved pool.
I've also tried to restructure the code a bit. I've added a new
SoilPoolsclass, which has method to calculate updates for all soil pools. I still feel like the contents of this method is a bit messy, but I couldn't see an obvious way to group the function steps that would make it clearer. I'm leaving this as is for now, but intended to refactor as further pools are addedFixes #605
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks