Skip to content

Revert "Bump numpy from 2.1.3 to 2.2.0 in the production-dependencies group"#641

Merged
davidorme merged 1 commit intodevelopfrom
revert-639-dependabot/pip/production-dependencies-19ddaf9521
Dec 16, 2024
Merged

Revert "Bump numpy from 2.1.3 to 2.2.0 in the production-dependencies group"#641
davidorme merged 1 commit intodevelopfrom
revert-639-dependabot/pip/production-dependencies-19ddaf9521

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

@davidorme davidorme commented Dec 16, 2024

Reverts #639

Numpy 2.2.0 changes some typing handling that raises issues - this failed pre-commit.ci as a result but that check wasn't required. So I'm backing this one off until it can pass.

I've made pre-commit.ci one of the required checks now - but because of the way it runs, we're getting that same failure. I'll have to force this push, but does this seem reasonable?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.62%. Comparing base (1a92bef) to head (fb967fa).
Report is 1219 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #641   +/-   ##
========================================
  Coverage    94.62%   94.62%           
========================================
  Files           73       73           
  Lines         4617     4617           
========================================
  Hits          4369     4369           
  Misses         248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure what's going on but I am in favor of reversing a change that broke everything ;-)

@davidorme davidorme merged commit 37f9ad8 into develop Dec 16, 2024
@davidorme davidorme deleted the revert-639-dependabot/pip/production-dependencies-19ddaf9521 branch December 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants