Skip to content

642 abiotic simple model add simple wind profile#643

Merged
vgro merged 4 commits intodevelopfrom
642-abiotic-simple-model-add-simple-wind-profile
Dec 17, 2024
Merged

642 abiotic simple model add simple wind profile#643
vgro merged 4 commits intodevelopfrom
642-abiotic-simple-model-add-simple-wind-profile

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Dec 17, 2024

The wind variable was missing from the simple model, therefore added with this PR

There were also a few variables hanging around that were not used, so I tidied that a bit.

Fixes #642

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Dec 17, 2024 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 17, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.63%. Comparing base (f72ecb4) to head (c8db6c5).
⚠️ Report is 2885 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #643   +/-   ##
========================================
  Coverage    94.62%   94.63%           
========================================
  Files           73       73           
  Lines         4617     4619    +2     
========================================
+ Hits          4369     4371    +2     
  Misses         248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from davidorme December 17, 2024 15:27
Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vgro vgro merged commit bf33499 into develop Dec 17, 2024
@vgro vgro deleted the 642-abiotic-simple-model-add-simple-wind-profile branch December 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abiotic simple model: add simple wind profile

3 participants