Make bypass setup and run update invalid in static models#693
Merged
Make bypass setup and run update invalid in static models#693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #693 +/- ##
===========================================
+ Coverage 94.74% 94.75% +0.01%
===========================================
Files 73 73
Lines 4984 4995 +11
===========================================
+ Hits 4722 4733 +11
Misses 262 262 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sallymatson
approved these changes
Jan 22, 2025
Collaborator
sallymatson
left a comment
There was a problem hiding this comment.
Great - I'll add this specification in the docs as well.
davidorme
requested changes
Jan 31, 2025
Collaborator
davidorme
left a comment
There was a problem hiding this comment.
The logic looks solid but a couple of things I'm not so clear on.
Collaborator
Author
|
@davidorme , I think I implemented all the changes requested here. Shall we merge, so it does not become stalled? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the possibility of skipping running the
_setupmethod but still running_updateonce, which is an invalid configuration for static models.As an extra, a bug is fixed by which the
_updatemethod was run in static models if no variables were present and None were required. If None are required, then the updated method should not run. Granted that is unlikely to happen in a real scenario, yet it should not happen ever.Fixes #687
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks