Skip to content

Remove depends section from schemas#694

Merged
davidorme merged 3 commits intodevelopfrom
660_update_schemas
Jan 30, 2025
Merged

Remove depends section from schemas#694
davidorme merged 3 commits intodevelopfrom
660_update_schemas

Conversation

@dalonsoa
Copy link
Copy Markdown
Collaborator

Description

Remove the depend section from all the schemas, which was a leftover from the previous approach and that is no longer relevant after implementing the variables system in full. The documentation is updated accordingly.

Fixes #660

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (84a3ee3) to head (800b331).
Report is 772 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #694   +/-   ##
========================================
  Coverage    94.66%   94.66%           
========================================
  Files           73       73           
  Lines         4833     4833           
========================================
  Hits          4575     4575           
  Misses         258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@sallymatson sallymatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@davidorme davidorme enabled auto-merge January 30, 2025 10:17
@davidorme davidorme merged commit aad2fc5 into develop Jan 30, 2025
@davidorme davidorme deleted the 660_update_schemas branch January 9, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant depends sections from model schema

5 participants