Skip to content

Adding python 3.13 as a supported version#725

Merged
jacobcook1995 merged 2 commits intodevelopfrom
722-we-dont-currently-support-python-313
Feb 4, 2025
Merged

Adding python 3.13 as a supported version#725
jacobcook1995 merged 2 commits intodevelopfrom
722-we-dont-currently-support-python-313

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR adds python 3.13 as a supported version so that if people install the most recent version of python they can actually download the package without having to roll back.

This PR would mean that we now support 4 versions of python, which I guess isn't really a problem. As far as I recall we discussed whether there were any syntax advantages to upgrading to 3.11 as a minimum version and we didn't think that there were. 3.10 also has about a year and a half of official support left, so there's no pressing need to drop it.

Fixes #722

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Feb 4, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.70%. Comparing base (a47852b) to head (00e93fe).
⚠️ Report is 2693 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #725   +/-   ##
========================================
  Coverage    94.70%   94.70%           
========================================
  Files           73       73           
  Lines         4946     4946           
========================================
  Hits          4684     4684           
  Misses         262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit 39f2f88 into develop Feb 4, 2025
@jacobcook1995 jacobcook1995 deleted the 722-we-dont-currently-support-python-313 branch February 4, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We don't currently support python 3.13

3 participants