Skip to content

Added step to catch infinite stochiometries#733

Merged
jacobcook1995 merged 1 commit intodevelopfrom
732-litter-model-needs-to-handle-infinite-stoichiometric-ratios
Feb 10, 2025
Merged

Added step to catch infinite stochiometries#733
jacobcook1995 merged 1 commit intodevelopfrom
732-litter-model-needs-to-handle-infinite-stoichiometric-ratios

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

I've added a new function to the litter model code that should catch any case where input organic matter stoichiometries or chemical proportions (in the case of lignin) go negative. This new function raises an error in this case as we have decided to treat this case as an error.

Fixes #732

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

…proportions from multiple litter input sources
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (ccc87e9) to head (3a54505).
Report is 705 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #733      +/-   ##
===========================================
+ Coverage    94.73%   94.74%   +0.01%     
===========================================
  Files           73       73              
  Lines         4974     4984      +10     
===========================================
+ Hits          4712     4722      +10     
  Misses         262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@TaranRallings TaranRallings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobcook1995 jacobcook1995 merged commit 8aa5af7 into develop Feb 10, 2025
@jacobcook1995 jacobcook1995 deleted the 732-litter-model-needs-to-handle-infinite-stoichiometric-ratios branch February 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Litter model needs to handle infinite stoichiometric ratios

3 participants