721 plantsmodel to use swdown radation

[sallymatson]

Change PPFD to DSR for main radiation input

Changed the plants input from PPFD to DSR. Added a conversion from DSR to PPFD in the plants _setup, as this unit is then used throughout the model.

Fixes #721

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist

• Make sure you've run the pre-commit checks: $ pre-commit run -a
• All tests pass: $ poetry run pytest

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works
• Relevant documentation reviewed and updated

[codecov-commenter]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.69%. Comparing base (e257921) to head (fd91a0b).
⚠️ Report is 2513 commits behind head on develop.

Files with missing lines	Patch %	Lines
...mple_data/generation_scripts/plant_example_data.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #741   +/-   ##
========================================
  Coverage    94.69%   94.69%           
========================================
  Files           74       74           
  Lines         5148     5149    +1     
========================================
+ Hits          4875     4876    +1     
  Misses         273      273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidorme]

This looks great.

Sorry for the slow response - please don't hesitate to kick me via Teams or email if you need stuff done. The GitHub emails are a blizzard so I don't track stuff well just from that.

I'm just checking with @vgro about the terminology: I've tended to see shortwave_downwelling_radiation and SWDown in the data I've used with pyrealm so it would be worth being consistent here, but the terminology may be more flexible than my narrow experience!

[sallymatson]

This looks great.

Sorry for the slow response - please don't hesitate to kick me via Teams or email if you need stuff done. The GitHub emails are a blizzard so I don't track stuff well just from that.

I'm just checking with @vgro about the terminology: I've tended to see shortwave_downwelling_radiation and SWDown in the data I've used with pyrealm so it would be worth being consistent here, but the terminology may be more flexible than my narrow experience!

No worries, thanks for looking it over!! And sounds good - I was just using what I found on google - but I definitely defer to the two of you on terminology. LMK what you prefer 😃

[davidorme]

We're happy with it as it is!