Replace CUE with a logistic expression#767
Merged
jacobcook1995 merged 11 commits intodevelopfrom May 22, 2025
Merged
Conversation
Collaborator
|
@jacobcook1995 would you be able to add this citation to Zotero and then the bibliography file so I can cite the new data? Thanks. |
hrlai
reviewed
Apr 2, 2025
hrlai
approved these changes
Apr 2, 2025
Collaborator
hrlai
left a comment
There was a problem hiding this comment.
Looks good to me, should be ready to merge once I update the constants and add a reference.
…ialCollegeLondon/virtual_ecosystem into feature/improved_cue_model
Collaborator
|
cool, I think I've added everything from this side and it is ready for you to take a final look. |
Collaborator
Author
|
@hrlai looks good! I'll fix the testing and merge it next week |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #767 +/- ##
========================================
Coverage 94.79% 94.79%
========================================
Files 75 75
Lines 5591 5592 +1
========================================
+ Hits 5300 5301 +1
Misses 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the current expression for CUE with a logistic expression. This is mainly so that the CUE can be parameterised to always be between 0 and 1.
@hrlai I've changed the function and constants so that it fits with the new model you suggested here. Once the data science side is sorted/merged you could add the values for the constants here.
Let me know how that goes! (also don't worry about the broken tests, they are mostly downstream stuff, I can fix them once you've made your changes)
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks