Skip to content

renamed hydrology constants#784

Merged
vgro merged 2 commits intodevelopfrom
783-rename-hydrology-constants
Mar 13, 2025
Merged

renamed hydrology constants#784
vgro merged 2 commits intodevelopfrom
783-rename-hydrology-constants

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Mar 13, 2025

This PR renames a few hydrology constants that were unclear.

Fixes #783

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Mar 13, 2025 that may be closed by this pull request
@vgro vgro requested a review from jacobcook1995 March 13, 2025 10:10
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (just had one small question)

water_retention_curvature: float = -7.22
"""Curvature of the water retention curve.
campbell_pore_size_distribution: float = -7.22
"""Curvature of the water retention curve as indicator of pore size distribution.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does Campbell mean here, is it from a specific model?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the reference to the constants; the reference is also in the function docstring.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.51%. Comparing base (93e79f1) to head (4877159).
⚠️ Report is 2415 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #784   +/-   ##
========================================
  Coverage    94.51%   94.51%           
========================================
  Files           74       74           
  Lines         5013     5013           
========================================
  Hits          4738     4738           
  Misses         275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro merged commit e458182 into develop Mar 13, 2025
16 checks passed
@vgro vgro deleted the 783-rename-hydrology-constants branch March 13, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename hydrology constants

3 participants