Conversation
jacobcook1995
approved these changes
Mar 13, 2025
Collaborator
jacobcook1995
left a comment
There was a problem hiding this comment.
LGTM! (just had one small question)
| water_retention_curvature: float = -7.22 | ||
| """Curvature of the water retention curve. | ||
| campbell_pore_size_distribution: float = -7.22 | ||
| """Curvature of the water retention curve as indicator of pore size distribution. |
Collaborator
There was a problem hiding this comment.
What does Campbell mean here, is it from a specific model?
Collaborator
Author
There was a problem hiding this comment.
I added the reference to the constants; the reference is also in the function docstring.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #784 +/- ##
========================================
Coverage 94.51% 94.51%
========================================
Files 74 74
Lines 5013 5013
========================================
Hits 4738 4738
Misses 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames a few hydrology constants that were unclear.
Fixes #783
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks