Skip to content

Removed soil_moisture_capacity from hydrology constants#785

Merged
jacobcook1995 merged 2 commits intodevelopfrom
768-soil_moisture_capacity-should-be-deleted-from-hydrology-constants
Mar 13, 2025
Merged

Removed soil_moisture_capacity from hydrology constants#785
jacobcook1995 merged 2 commits intodevelopfrom
768-soil_moisture_capacity-should-be-deleted-from-hydrology-constants

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR removes the soil_moisture_capacity from HydroConsts as it is duplicated in CoreConsts, which is a possible source of confusion.

Fixes #768

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Mar 13, 2025 that may be closed by this pull request
@jacobcook1995 jacobcook1995 requested a review from vgro March 13, 2025 10:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (c3a2907) to head (644d4c0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #785      +/-   ##
===========================================
- Coverage    94.54%   94.54%   -0.01%     
===========================================
  Files           74       74              
  Lines         5040     5038       -2     
===========================================
- Hits          4765     4763       -2     
  Misses         275      275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 merged commit e84a596 into develop Mar 13, 2025
16 checks passed
@jacobcook1995 jacobcook1995 deleted the 768-soil_moisture_capacity-should-be-deleted-from-hydrology-constants branch March 13, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

soil_moisture_capacity should be deleted from hydrology constants

3 participants